Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c_api] Improve ANSI compatibility by avoiding <stdbool.h> #4697

Merged
merged 6 commits into from
Nov 15, 2021
Merged

[c_api] Improve ANSI compatibility by avoiding <stdbool.h> #4697

merged 6 commits into from
Nov 15, 2021

Conversation

drewmiller
Copy link
Contributor

Mentioned in #4609, these edits improve ANSI C compatibility by removing reliance on stdbool.h. These edits may cause a compiler warning for existing code which passes a _Bool pointer as out. However, given the brief tenure of ANSI C compatibility, it seems unlikely there will be much breakage.

StrikerRUS
StrikerRUS requested changes Oct 19, 2021
View reviewed changes
.ci/test.sh Outdated Show resolved Hide resolved
include/LightGBM/c_api.h Outdated Show resolved Hide resolved
StrikerRUS
StrikerRUS approved these changes Oct 22, 2021
View reviewed changes
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for your contribution!

@shiyu1994
Copy link
Collaborator

Shall we change the call of LGBM_BoosterGetLinear in basic.py?

LightGBM/python-package/lightgbm/basic.py

Lines 3569 to 3572 in dc02dca

out_is_linear = ctypes.c_bool(False)
_safe_call(_LIB.LGBM_BoosterGetLinear(
self.handle,
ctypes.byref(out_is_linear)))

Since _Bool may have smaller size than int, it seems that we can wrongly set some unallocated bytes when calling LGBM_BoosterGetLinear.

StrikerRUS
StrikerRUS requested changes Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we change the call of LGBM_BoosterGetLinear in basic.py?

Ah, indeed, we definitely should! Sorry, I missed this one call of LGBM_BoosterGetLinear across the whole LightGBM codebase.

@drewmiller Could you please update the linked Python code or do you need any help with it?

@StrikerRUS
Copy link
Collaborator

Kindly ping @drewmiller

@drewmiller
Copy link
Contributor Author

Kindly ping @drewmiller

Apologies for the delay. Will make the change this weekend.

@StrikerRUS
Copy link
Collaborator

No problem, please take your time. I just wanted to make sure you didn't forget about this PR.

@StrikerRUS StrikerRUS requested review from shiyu1994 and removed request for shiyu1994 November 14, 2021 00:52
jameslamb
jameslamb approved these changes Nov 14, 2021
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @drewmiller !

@shiyu1994 shiyu1994 merged commit bfb346c into microsoft:master Nov 15, 2021
@jameslamb jameslamb mentioned this pull request Nov 29, 2021
Merged
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
Closed
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
Closed
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StrikerRUS StrikerRUS StrikerRUS approved these changes

@jameslamb jameslamb jameslamb approved these changes

@btrotta btrotta Awaiting requested review from btrotta

@chivee chivee Awaiting requested review from chivee

@guolinke guolinke Awaiting requested review from guolinke guolinke is a code owner

@henry0312 henry0312 Awaiting requested review from henry0312

@hzy46 hzy46 Awaiting requested review from hzy46

@tongwu-sh tongwu-sh Awaiting requested review from tongwu-sh

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drewmiller @shiyu1994 @StrikerRUS @jameslamb